Store Page
Slay the Spire
All Discussions Screenshots Artwork Broadcasts Videos Workshop News Guides Reviews

Slay the Spire

Store Page
Slay the Spire >  Workshop > Ocean's Workshop > The Bogwarden > Discussions
The Bogwarden
Description Discussions2 Comments18 Change Notes
Sagil 12 Feb, 2024 @ 5:45am
Mod conflict
I ran into an issue where traps aren't triggering due to a conflict with another mod (Nimble). Both mods are patching AbstractPlayer.damage, which causes the conflict. I'm wondering if your mod could instead register an OnPlayerDamagedSubscriber with BaseMod.subscribe, which should cause fewer conflicts in general and resolve this one in particular.
Last edited by Sagil; 12 Feb, 2024 @ 6:50am
< >
Showing 1-4 of 4 comments
Ocean  [developer] 12 Feb, 2024 @ 9:05am 
i tend to avoid basemod hooks outside of the registering ones and im not sure how nimble mod works nor do i really care about cross mod stuff like this so i dont intend to fix this myself but bogwardens github is linked on the workshop page so ill accept a pull request if you wanna take a crack at it
#1
Sagil 13 Feb, 2024 @ 12:50am 
Created a pull request. Turns out that OnPlayerDamageSubscriber also triggers when damage is blocked, so had to patch into another function instead. The solution isn't 100% perfect as the trap target will be random, but since this is a fallback it only matters if the usual triggers don't work for whatever reason, and a random target it better than no target at all.
Last edited by Sagil; 13 Feb, 2024 @ 1:40am
#2
Ocean  [developer] 13 Feb, 2024 @ 9:05am 
left a review on your PR
#3
Sagil 13 Feb, 2024 @ 11:51pm 
Noticed another minor conflict with Battle Towers, where the visual effect from Briar Patch is not removed after combat while in the tower.
#4
< >
Showing 1-4 of 4 comments
Per page: 1530 50