Looks to be working just fine on 1.6!

would be so nice if you would update your mod to 1.6 i love it hig hearts :) <3

Anyone know if this is working on 1.6?

Also you need Harmony as a dependency in the About.xml

Yup that works, just change the defName=""TorchWallLamp" to @Name="TorchBase"

Or it looks like you should just be able to patch the parent @Name="TorchBase" as you did previously with the AttributeSet patch

@An Ol' Spicy Keychain Your patch for TorchLamp needs changing to not replace the entire <comps> section, that breaks a lot of mods patches as they get overwritten. I'm not sure what the issue was exactly for 1.5, but if you were having issues with Add, try replacing individual comps using Conditional patches to check if things exist. This will avoid errors

Please could add compatibility for the hearth from VFE Medieval 2? Thanks!

Nice little mod, that works very well.

Bit late but since no one else seems to know I tested it with 1.4 and the overhaul and it does not sadly. @notbuddhanuff

Does this work with Medieval Overhaul?

tell me something i don't know, "plz fix" is a complete rewrite lmao
aint nobody got time for dat
i offer my mods free, as-is and without warranty! feel free to commission someone on the mod market for a better mod

I'd like to reiterate the comparability problem with Better Pyromania. I've already discossed this with the mod dev and he states
"They replace the CompFireOverlay on torch lamps with their own class that is not a subclass of the vanilla base class, and thus it no longer is recognized by any firewatching logic, including the vanilla Pyromaniac feat's firewatcher . This is a problem that they need to fix, because it affects more than just this mod."

Please fix this.

Made you a patch for Medieval - Less Wood Please

<!-- Less Wood -->
<Operation Class="PatchOperationFindMod">
<mods>
<li>Medieval - Less Wood Please</li>
</mods>
<match Class="PatchOperationSequence">
<operations>
<li Class="PatchOperationAdd"><!-- added without removing -->
<order>Prepend</order>
<xpath>Defs/ThingDef[defName="MetalTorchLamp"]/comps</xpath>
<value>
<li Class="CompProperties_Flickable" />
</value>
</li>
<li Class="PatchOperationAttributeSet">
<xpath>Defs/ThingDef[defName="MetalTorchLamp"]/comps/li[@Class="CompProperties_FireOverlay"]</xpath>
<value>MaliExtinguishRefuelables.CompProperties_FireOverlayExtinguishable</value>
<attribute>Class</attribute>
</li>
</operations>
</match>
</Operation>

that would be cool, outside of my capability though im afraid hehe

Hey, thanks for the mod, i really appreciate your the work you do! On a seperate note, i thought it would be a neat idea to have a schedule so they can be automatically designated to be flicked.

Is there any chance of making this compatible with "Better Pyromania". At the moment, if both are active, the Pyro doesn't get Fire Need increase from being near torches or camps or such. If not, oh well. But I thought I'd ask. Thanks for the mod work, regardless.

Hey, that was super fast, thank you for your quick work! A+ mod, honestly frustrating playing without it. Have a good day! :)

alright, torch is fixed, disabled better pyromania patch for now as it breaks devmode when the mod is not loaded (all the patch does is stop fire need from increasing from doused fires)

thanks for the report, ill look into it soon

Thanks so much for updating! Getting errors now, though. Here's a series of steps taken in order to get it into 1.5:

1) Core + Biotech + ExtRef only: game says "Recovered from incompatible or corrupted mods errors," and that all mods have been disabled.

Tried Harmony, just in case:

2) Harmony + C + BioT + ER only: mod then loads, but you can't load the "debug actions" menu. Gives the ff. error:

"Exception filling window for Verse.ImmediateWindow: System.TypeLoadException: Could not resolve type with token 01000016 (from typeref, class/assembly BetterPyromania.Need_Pyromania, BetterPyromania, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null)
[Ref CB96FBA0]"

I see "BetterPyromania" there, subscribe to that just for this, and next:

3) H + C + BioT + ER + Better Pyro only: Debug actions menu loads now. Works great on campfire and wall torch, but toggling a floor torch only turns off the light radius, but the flame animation is still on.

Hope this all makes sense!

Thanks a lot!

This is a nice and useful mod. Can one suggestions mod?

there we are, 1.5
had a hell of a time cleaning up some old messes i made, including updating and adding mod compatibility patches and bugfixes, thanks for your patience everyone

yeah fixing that is part of the update, the patchoperations were an experiment that i'd thought succeeded at the time lol

Thank you for this essential mod and your work on the update! This mod works fine for me with 1.5, but I got an error from the XML patches. I took a look at them and noticed that you're using MayRequire in an Operation tag which isn't possible. It only works if the PatchOperation is a list item in a sequence. In my local files I put the DLC patches in a sequence, and the error was gone.

Thanks for the impending update, Spicy!

Awesome, thank you so much!

should work fine except for darklights, will update soon

Anyone try with 1.5?

Love this. Unfortunately still gives off heat with the "Proxy heat" mod

Must have for cowboy roleplay, muchos gracias!

oh, how kind of you, thanks. unfortunately i dont have the time or focus to keep on top of compatibility for my mods, as selfish as that is of me, so it means a lot :)

@An Ol' Spicy Keychain you can ignore the request for RimIgnition C# Edition support, I have it taken care of on my end

I would love to see this patched to work with VFE Vikings and Classical, and maybe even Medieval Lighting and Heat :)
Thanks!

@Catch Lightning could be a load order issue, if that mod also patches campfire comps
try swapping the load order of the 2 mods

Unlike @Catch Lightning, I have no conflict between this mod and No Default Gather Spot.

Not a huge deal but this conflicts with No Default Gather Spot. If you put out a campfire then reignite it it sets it as a gather spot again. I'm kinda tired of barn parties.

The mod Apothecary (Continued) adds a Charcoal Brazier that functions similarly to a campfire. I used the code in your patch you made for the Stone Campfire to create similar code for the Charcoal Brazier so it can be extinguished. It seems to work just fine, but the tool-tip/graphic acts like it's an electric item (Toggle power instead of extinguish. Same graphic that an electric heater has.). Otherwise it's perfectly functional. Would you be interested in having the exact code? And If so, should I post it here or through a dm?

royalty defs and patch but no check if it is even loaded, throwin lots of red errors, maybe check and tidy up? =)

Like others said, it'd make a lot of sense to patch this to work with medieval overhaul. Never really had a use for fire outside of using that.

I’d really appreciate if you could patch medieval overhaul to have extinguishing?

XML error on load:
[Extinguish Refuelables] Patch operation Verse.PatchOperationAttributeSet(Defs/ThingDef[defName="Brazier" or defName="DarklightBrazier" or defName="Darktorch" or defName="DarktorchFungus"]/comps/li[@Class="CompProperties_FireOverlay"])(Class) failed
file: C:\Program Files (x86)\Steam\steamapps\workshop\content\294100\2864470385\Patches\Extinguish_Patch.xml

A couple suggestions to patch:
1) Signal Fire https://steamhost.cn/steamcommunity_com/sharedfiles/filedetails/?id=2026582975
2) Smoked meat — Smokepit https://steamhost.cn/steamcommunity_com/sharedfiles/filedetails/?id=1542364782

Hey man great mod! Is it possible to make it so that your pawn automatically snuff the fire at sunset and light it back up at sun down? Thank you still for the mod!

Oh and the Hearth from VFE Vikings ?

Hey, would it be possible to add a patch for the Wood burning stove and the Hearth of medieval overhaul ?

https://steamhost.cn/steamcommunity_com/sharedfiles/filedetails/?id=2882277375&searchtext=medieval

finally

probably not going to support on my end, my mod is primarily a utility mod to not waste fuel, not an aesthetic one

Conflicts with mods that remove the refuel need for torches, making them not show the fire animation when on, like this one: https://steamhost.cn/steamcommunity_com/sharedfiles/filedetails/?id=2687885267
To be honest, I'm dumb for not noticing the obvious